Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature attach options #718

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Sep 13, 2021

Add options subcommand to attach

fixes #688

  • the options subcommand of attach functions the same,
    as the options subcommand of creating the normal session,
    but not every option will have an effect on reattaching,
    for example the default_mode setting would make no sense
    to switch.

    In the future it would make sense to be able to hot swap some
    of the options on reattach, but we are not able to do that yet,
    for example the default_shell one.

    Eg:

    zellij attach <session-name> options --theme <theme>
    

fixes zellij-org#688

- the `options` subcommand of `attach` functions the same,
  as the `options` subcommand of creating the normal session,
  but not every option will have an effect on reattaching,
  for example the `default_mode` setting would make no sense
  to switch.

  In the future it would make sense to be able to hot swap some
  of the options on reattach, but we are not able to do that yet,
  for example the `default_shell` one.

  Eg:

  ```
  zellij attach <session-name> options --theme <theme>
  ```
@a-kenji a-kenji merged commit 9a5a315 into zellij-org:main Sep 13, 2021
@a-kenji a-kenji deleted the feature-attach-options branch June 7, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zellij attach should also accept options (eg. disable-mouse-mode)
1 participant